Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip OVAL schematron validation in CI #10960

Merged

Conversation

jan-cerny
Copy link
Collaborator

Stop performing OVAL schematron validation in our GitHub Actions CI. The additional validation takes a lot of time and slows down tests significantly. OTOH the value that it adds is low. Most of the problems will be discovered by XML schema validation which we keep in the tests. Advanced problems are discovered in SCAPVal runs that are also a part of our daylife.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Stop performing OVAL schematron validation in our GitHub Actions CI.
The additional validation takes a lot of time and slows down tests
significantly. OTOH the value that it adds is low. Most of the problems
will be discovered by XML schema validation which we keep in the tests.
Advanced problems are discovered in SCAPVal runs that are also a part
of our daylife.
@jan-cerny jan-cerny added the Test Suite Update in Test Suite. label Aug 8, 2023
@jan-cerny jan-cerny added this to the 0.1.70 milestone Aug 8, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit 97f1f7d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Aug 8, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builds on this PR do look to be a bit faster. Thanks for the PR!

@Mab879 Mab879 merged commit fdc7128 into ComplianceAsCode:master Aug 8, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants