Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional rules from CIS Level 1 to SAP hardening profile #10965

Conversation

brett060102
Copy link
Contributor

Include some rules and required vars from CIS Level 1 to SUSE SAP hardening profile.

Description:

  • Users have requested that the as many of the CIS Level 1 rules be included in the SAP hardened image as possible.
  • We looked at each rule and determined which one could be applied at image build time.
  • We also validated that the resulting image worked with SAP
  • We did look at pulling in all of the CIS Level 1 rules, and black listing the ones we knew to be incompatible, but decided to use an explicit list instead to isolate our build process from changes/additions in the CIS Level 1 profile
  • We decided against adding these to the generic hardening profile since it is intended for general purpose use and can't make the same assumption for it that we can for the SAP profile.

Rationale:

  • response to user requests for greater initial system security

Include some rules and required vars from CIS Level 1
to SUSE SAP hardenning profile.
@brett060102 brett060102 requested a review from a team as a code owner August 8, 2023 21:54
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

Hi @brett060102. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit d9e6187 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@brett060102
Copy link
Contributor Author

I looked at the:
Gate / Build, Test on Fedora Rawhide (Container) (pull_request)
Does no look like i is the result of my change.

@marcusburghardt marcusburghardt added SLES SUSE Linux Enterprise Server product related. CIS CIS Benchmark related. labels Aug 9, 2023
@marcusburghardt
Copy link
Member

FYI @teacup-on-rockingchair

Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@teacup-on-rockingchair teacup-on-rockingchair merged commit b739952 into ComplianceAsCode:master Aug 12, 2023
32 of 33 checks passed
@brett060102 brett060102 deleted the suse-hardening-updates branch August 14, 2023 14:35
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 14, 2023
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants