Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sshd_approved_ciphers value for RHEL in STIG profile #10966

Merged

Conversation

marcusburghardt
Copy link
Member

Description:

Update sshd_approved_ciphers value for RHEL8 STIG
Update sshd_approved_ciphers value for RHEL9 STIG Draft

Rationale:

Better alignment of crypto related settings for SSH.

It is somehow related to the following issues:

@marcusburghardt marcusburghardt added RHEL9 Red Hat Enterprise Linux 9 product related. RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. labels Aug 9, 2023
@marcusburghardt marcusburghardt requested a review from a team as a code owner August 9, 2023 09:56
@marcusburghardt
Copy link
Member Author

@Mab879 and @ggbecker , could you take a look and double check the changes in this PR, please? I also suspect that some issues mentioned in the description might be closed.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 9, 2023

Code Climate has analyzed commit 051c133 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Aug 9, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Aug 9, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM.

@Mab879 Mab879 merged commit b22ab92 into ComplianceAsCode:master Aug 9, 2023
33 of 34 checks passed
@marcusburghardt marcusburghardt deleted the sshd_approved_ciphers_stig branch August 9, 2023 19:30
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants