Improve rendering controls to HTML #10994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will generate HTML pages only for controls that are actually used in the product. That means we will stop generating bizzare pages like "CIS benchmark for SUSE Linux Enterprise 15 for RHEL 7". A side effect is that the build will be faster. Fixes: ComplianceAsCode#10791
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
marcusburghardt
added
enhancement
marcusburghardt
requested changes
Aug 16, 2023
|
I have removed the unused import |
|
Code Climate has analyzed commit a64cbb1 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.3% (0.0% change). View more on Code Climate. |
marcusburghardt
merged commit 082c304
into
ComplianceAsCode:master
32 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will generate HTML pages only for controls that are actually used in the product. That means we will stop generating bizzare pages like "CIS benchmark for SUSE Linux Enterprise 15 for RHEL 7". A side effect is that the build will be faster.
Fixes: #10791
Review Hints:
python3 utils/render_all_policies.py --output-dir /tmp/out --ssg-root $(pwd) --product rhel9