Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rules not relevant to RHEL 9 from STIG profile #10996

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • remove two rules from RHEL 9 STIG
    • harden_sshd_macs_openssh_conf_crypto_policy
    • harden_sshd_ciphers_openssh_conf_crypto_policy

Rationale:

  • rules do not have remediations for RHEL 9

Review Hints:

  • build master and copy the compiled profile somewhere
  • compare with this branch
  • rules mentioned in the description should not be present

rules have no remediation for RHEL 9, syntax for RHEL 9 is also different than RHEL 8
@vojtapolasek vojtapolasek added RHEL9 Red Hat Enterprise Linux 9 product related. STIG STIG Benchmark related. labels Aug 15, 2023
@vojtapolasek vojtapolasek added this to the 0.1.70 milestone Aug 15, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 15, 2023

Code Climate has analyzed commit 509c117 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@jan-cerny
Copy link
Collaborator

Additional context: This PR is related to issue #10664, where these 2 rules were reported as failing. The issue was closed but no action was taken about these 2 rules back then.

@marcusburghardt marcusburghardt self-assigned this Aug 16, 2023
@marcusburghardt
Copy link
Member

It complements the #10877

@marcusburghardt marcusburghardt merged commit 42bce12 into ComplianceAsCode:master Aug 16, 2023
33 of 35 checks passed
@marcusburghardt
Copy link
Member

FYI @ggbecker and @Mab879

@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL9 Red Hat Enterprise Linux 9 product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants