Remove "not available" message #10998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the HTML controls pages, the variables are shown with a "not available in this product" message, which is incorrect. This message makes sense only with rules selections but not with variables selections.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
The readers of the policy HTML page will be able to click on a link that leads to the upstream definition of an XCCDF Value on GitHub. This is similar to the link that we provide for rules.
|
I have add a HTML link to XCCDF Values |
|
Code Climate has analyzed commit 58e3355 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.3% (0.0% change). View more on Code Climate. |
marcusburghardt
merged commit 2bf1870
into
ComplianceAsCode:master
32 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the HTML controls pages, the variables are shown with a "not available in this product" message, which is incorrect. This message makes sense only with rules selections but not with variables selections.
Review Hints:
python3 utils/render_all_policies.py --output-dir /tmp/out --ssg-root $(pwd) --product rhel9
firefox /tmp/out/anssi.html