Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ansible Remediation for directory_ownership_var_log_audit #11012

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Aug 22, 2023

Description:

Add Ansible Remediation for directory_ownership_var_log_audit

Rationale:

  • Ansible parity

@Mab879 Mab879 added the Ansible Ansible remediation update. label Aug 22, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Aug 22, 2023
@Mab879 Mab879 force-pushed the add_ansible_directory_ownership_var_log_audit branch from 30e7179 to 2e0d83d Compare August 22, 2023 21:27
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New datastream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_directory_ownership_var_log_audit'.

@Mab879 Mab879 marked this pull request as draft August 22, 2023 21:54
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 22, 2023
@ggbecker
Copy link
Member

/packit retest-failed

@Mab879 Mab879 force-pushed the add_ansible_directory_ownership_var_log_audit branch 2 times, most recently from ff171d7 to b3a3620 Compare August 23, 2023 23:36
@Mab879 Mab879 marked this pull request as ready for review August 23, 2023 23:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 23, 2023
@Mab879 Mab879 force-pushed the add_ansible_directory_ownership_var_log_audit branch from b3a3620 to 271f93f Compare August 24, 2023 02:02
@marcusburghardt marcusburghardt self-assigned this Aug 24, 2023
…audit

* Add test for custom path and not configured correctly
* Add test for not configured path not correctly
* Add tests for correctly configured custom path
@Mab879 Mab879 force-pushed the add_ansible_directory_ownership_var_log_audit branch from 271f93f to 6cb216f Compare August 24, 2023 12:30
@codeclimate
Copy link

codeclimate bot commented Aug 24, 2023

Code Climate has analyzed commit 6cb216f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@marcusburghardt
Copy link
Member

/retest

@marcusburghardt
Copy link
Member

Automatus tests can be safely waived in this PR. The failure is not caused by this PR.
Tests in local VMs worked as expected.

@marcusburghardt marcusburghardt merged commit 52a82f9 into ComplianceAsCode:master Aug 25, 2023
33 of 38 checks passed
@Mab879 Mab879 deleted the add_ansible_directory_ownership_var_log_audit branch August 25, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants