Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product as parameter when building profile reports #11023

Merged

Conversation

teacup-on-rockingchair
Copy link
Contributor

Description:

  • Make sure that the product paramter is passed when building profile stats

Rationale:

  • Until now only the STIG references worked for SLE products
    Now when one runs:
# python3 build-scripts/profile_tool.py stats --benchmark build/ssg-sle15-xccdf.xml --profile xccdf_org.ssgproject.content_profile_cis --missing-cis-refs --product sle15

The result is much more close to reality:

Profile cis:
* rules:              375
* checks (OVAL):      359	[95% complete]
* checks (SCE):       0	[0% complete]
* checks (any):       359	[95% complete]
* fixes (bash):       337	[89% complete]
* fixes (ansible):    328	[87% complete]
* fixes (ignition):   0	[0% complete]
* fixes (kubernetes): 0	[0% complete]
* fixes (puppet):     64	[17% complete]
* fixes (anaconda):   1	[0% complete]
* fixes (any):        338	[90% complete]
* CCEs:               374	[99% complete]
*** rules of 'xccdf_org.ssgproject.content_profile_cis' profile missing CIS Refs: 373 of 375 have them [0% missing]
   xccdf_org.ssgproject.content_rule_dconf_db_up_to_date
   xccdf_org.ssgproject.content_rule_set_iptables_default_rule_forward

Make sure that the product paramter is passed when building profile stats
@teacup-on-rockingchair teacup-on-rockingchair added the Infrastructure Our content build system label Aug 24, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review August 24, 2023 13:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 24, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 24, 2023

Code Climate has analyzed commit 4332d85 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Aug 25, 2023
@jan-cerny jan-cerny added this to the 0.1.70 milestone Aug 25, 2023
@jan-cerny
Copy link
Collaborator

/packit retest-failed

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the profile_tool.py command, I have executed the build targets sle15-stats and sle15-profile-stats. The output of these operations looks good to me.

@jan-cerny jan-cerny merged commit 5707d37 into ComplianceAsCode:master Aug 25, 2023
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants