Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable logrotate.timer check on RHCOS4 #11045

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Enable logrotate.timer check on RHCOS4 #11045

merged 1 commit into from
Sep 11, 2023

Conversation

yuumasato
Copy link
Member

Description:

  • Enable check for logrotate.timer on rhcos4.
    From 4.13 RHCOS4 is based on RHEL9, so this check can be enabled.

Rationale:

  • On 4.13, the timer for logrotate is enabled by default.
  • And on 4.12 and older, the daily cron job for logrotate is enabled by default.

Fixes:

  • ensure_logrotate_activated result after remediation with compliance-operator
  • CI run on rhcos4-moderate and high.

Related:

@yuumasato
Enable lograte timer check on RHCOS4
5eee3f2 
From 4.13 RHCOS4 is based on RHEL9, thus this check can be enabled.

On 4.13, the timer for logrotate is enabled by default.
And on 4.12 and older, the daily cron job for logrotate is enabled by
default.
@yuumasato yuumasato added the OpenShift OpenShift product related. label Sep 4, 2023
@yuumasato yuumasato changed the title Enable lograte timer check on RHCOS4 Enable logrotate.timer check on RHCOS4 Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 4, 2023

Code Climate has analyzed commit 5eee3f2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@yuumasato
Copy link
Member Author

/test help

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

@yuumasato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-ocp4-cis
  • /test e2e-aws-ocp4-cis-node
  • /test e2e-aws-ocp4-e8
  • /test e2e-aws-ocp4-high
  • /test e2e-aws-ocp4-high-node
  • /test e2e-aws-ocp4-moderate
  • /test e2e-aws-ocp4-moderate-node
  • /test e2e-aws-ocp4-pci-dss
  • /test e2e-aws-ocp4-pci-dss-node
  • /test e2e-aws-ocp4-stig
  • /test e2e-aws-ocp4-stig-node
  • /test e2e-aws-rhcos4-e8
  • /test e2e-aws-rhcos4-high
  • /test e2e-aws-rhcos4-moderate
  • /test e2e-aws-rhcos4-stig
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-ComplianceAsCode-content-master-images

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuumasato
Copy link
Member Author

/test e2e-aws-rhcos4-high
/test e2e-aws-rhcos4-moderate

Vincent056
Vincent056 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

rhmdnd
rhmdnd approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit 7d537f6 into ComplianceAsCode:master Sep 11, 2023
39 of 40 checks passed
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 11, 2023
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Sep 11, 2023
@yuumasato yuumasato deleted the check_logrotate_timer_on_rhcos4 branch September 12, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vincent056 Vincent056 Vincent056 approved these changes

@rhmdnd rhmdnd rhmdnd approved these changes

Assignees

@Vincent056 Vincent056

@rhmdnd rhmdnd

Labels
OpenShift OpenShift product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.70
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuumasato @Vincent056 @rhmdnd @Mab879