Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UBTU-20-010181 for generating audit record for unsuccessful attem… #11057

Conversation

dexterle
Copy link
Contributor

@dexterle dexterle commented Sep 7, 2023

Description:

  • Add UBTU-20-010181
  • Removes UBTU-20-010302
  • Fix remediations and OVAL definitions for Ubuntu

Rationale:

Review Hints:

Build the product:

./build_product ubuntu2004

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2004-playbook-stig.yml --tags "DISA-STIG-UBTU-20-010181"

To test changes with bash, run the remediation section: xccdf_org.ssgproject.content_rule_audit_rules_kernel_module_loading_delete

Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.

git checkout dexterle:add-manual-stig-ubtu-20-v1r9

This STIG can be tested with the latest Ubuntu 2004 Benchmark SCAP. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Used by openshift-ci bot. needs-ok-to-test Used by openshift-ci bot. labels Sep 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

Hi @dexterle. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt
Copy link
Member

I know it is in Draft, so it is just a kind remind to update the PR description.

@marcusburghardt marcusburghardt added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels Sep 8, 2023
@dodys dodys self-assigned this Sep 8, 2023
@dexterle dexterle marked this pull request as ready for review September 11, 2023 12:32
@dexterle dexterle requested a review from a team as a code owner September 11, 2023 12:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Sep 11, 2023
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small change needed if you want to have ansible remediation

@@ -4,7 +4,7 @@
# disruption = low
# strategy = configure

{{% if "ol" in product or 'rhel' in product %}}
{{% if "ol" in product or 'rhel' in product or 'ubuntu' in product %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add multi_platform_ubuntu to this ansible platforms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback. This was originally added in this commit in the original PR but the commit was modifying too many rules. I'll add this in when I get the chance

e7d99c0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

This commit will fix the delete_module to specify the proper parameters for UBTU-20-010181
@dexterle dexterle force-pushed the add-rules-ubtu-20-010181-remove-ubtu-20-010302 branch from 7b2d7d9 to 110f27e Compare September 12, 2023 14:20
@codeclimate
Copy link

codeclimate bot commented Sep 12, 2023

Code Climate has analyzed commit 110f27e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 1a58c4f into ComplianceAsCode:master Sep 12, 2023
36 of 37 checks passed
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 12, 2023
@Mab879 Mab879 added Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates. and removed Update Profile Issues or pull requests related to Profiles updates. labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants