Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UBTU-20-010461 to ensure kernel module usb-storage is blacklisted… #11062

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Add UBTU-20-010461 to ensure kernel module usb-storage is blacklisted… #11062

merged 1 commit into from
Sep 12, 2023

Conversation

dexterle
Copy link
Contributor

@dexterle dexterle commented Sep 7, 2023 •
edited

Description:

  • Add UBTU-20-010461
  • Modify ansible template for kernel_module_disable to add ubuntu2004 support

Rationale:

Review Hints:

Build the product:

./build_product ubuntu2004

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2004-playbook-stig.yml --tags "DISA-STIG-UBTU-20-010461"

To test changes with bash, run the remediation section: xccdf_org.ssgproject.content_rule_kernel_module_usb-storage_disabled

Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.

git checkout dexterle:add-manual-stig-ubtu-20-v1r9

This STIG can be tested with the latest Ubuntu 2004 Benchmark SCAP. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Used by openshift-ci bot. needs-ok-to-test Used by openshift-ci bot. labels Sep 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

Hi @dexterle. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels Sep 8, 2023
@dexterle dexterle marked this pull request as ready for review September 11, 2023 12:57
@dexterle dexterle requested a review from a team as a code owner September 11, 2023 12:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Sep 11, 2023
@dexterle dexterle force-pushed the add-rule-ubtu-20-010461 branch 2 times, most recently from 292c566 to f565c35 Compare September 12, 2023 18:04
dodys
dodys requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small addition

shared/templates/kernel_module_disabled/ansible.template Show resolved Hide resolved
@dexterle
Add UBTU-20-010461 to ensure kernel module usb-storage is blacklisted…
79b42a2 
… and disabled

This commit will implement UBTU-20-010461 remediation for usb-storage kernel module. This will add in ubuntu2004 into the kernel template to blacklist usb-storage. Additionally, the STIG id has been added to the v1r8 profile.

Conflicts:
	products/ubuntu2004/profiles/stig.profile
@codeclimate
Copy link

codeclimate bot commented Sep 12, 2023

Code Climate has analyzed commit 79b42a2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@dodys dodys self-assigned this Sep 12, 2023
@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Sep 12, 2023
dodys
dodys approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, much appreciated!

@dodys dodys merged commit 65865b0 into ComplianceAsCode:master Sep 12, 2023
38 checks passed
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 12, 2023
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
@mpurg mpurg mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels
ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.70
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dexterle @dodys @Mab879 @marcusburghardt