Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Profile Improvements #11109

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Sep 12, 2023

Description:

Update the standard profile for RHEL 7 and RHEL 8.

Rationale:

The standard profile was in rough shape and it had some glaring issues in it. The goal of this PR is better round out this profile.

These files should have the correct permissions all systems.
Audit rules are a bit useless if the audit service is not enaabled.
Without this it is possible configure at system in a bad state.
These files contain high value data and should be protected.
As these files contain configuration that can used to elvate
a user's access.
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Sep 12, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 12, 2023
@Mab879 Mab879 requested a review from a team as a code owner September 12, 2023 00:42
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 12, 2023

Code Climate has analyzed commit 7cabef9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Sep 12, 2023
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements and the clear commit messages.

@marcusburghardt marcusburghardt merged commit 556ba22 into ComplianceAsCode:master Sep 12, 2023
38 checks passed
@marcusburghardt marcusburghardt added the standards Benchmarks related. label Sep 12, 2023
@Mab879 Mab879 deleted the standard_improvement branch September 12, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standards Benchmarks related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants