Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package_audit-libs_installed rule.yml #11127

Merged

Conversation

Whidix
Copy link
Contributor

@Whidix Whidix commented Sep 20, 2023

Fix package_audit-libs_installed rule for sles

Description:

  • On sles, libaudit is part of the libaudit1 package

On sles, the package name is libaudit1
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Sep 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

Hi @Whidix. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Whidix Whidix changed the title Update package_audit-libs_installed rule.yml Fix package_audit-libs_installed rule.yml Sep 20, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel7 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 20, 2023

Code Climate has analyzed commit 05e058b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.8% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Sep 20, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen in a SLE 15 container that libaudit1 is the correct name.

The Automatus fail on SUSE15 is expected because the rule has the machine platform but the CI job runs tests on a container back end. The Automatus fails on other platforms are expected because the rules aren't part of these products.

Thank you for your patch.

@jan-cerny jan-cerny merged commit d47677e into ComplianceAsCode:master Sep 20, 2023
33 of 37 checks passed
@jan-cerny jan-cerny added the SLES SUSE Linux Enterprise Server product related. label Sep 20, 2023
@jan-cerny jan-cerny added this to the 0.1.70 milestone Sep 20, 2023
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants