-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of derivatives to Automatus #11129
Conversation
Extract function `get_product_id` to reduce cognitive complexity and allow easier extension.
If a derivative data stream (eg. ssg-cs9-ds.xml) is tested, Automatus will now automatically infer which product this derivative is derived from. Fixes: ComplianceAsCode#10677
Code Climate has analyzed commit db3e7a1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 56.8% (0.0% change). View more on Code Climate. |
/retest |
@jan-cerny: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/tests images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that my reproducer in #10677 is fixed along with the provided example works.
Thanks for the fix!
Description:
If a derivative data stream (eg. ssg-cs9-ds.xml) is tested, Automatus will now automatically infer which product this derivative is derived from.
Rationale:
Fixes: #10677
Review Hints:
./build_product rhel9 --derivatives
./tests/automatus.py rule --datastream build/ssg-cs9-ds.xml --remove-platforms --remove-machine-only --libvirt qemu:///system ssgts_rhel9 selinux_state