New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-8041: Remove info override for vsyscall kernerl argument #11329
Conversation
This rule actually has the ability to check the kernel arguments, and generates a remediation if necessary. Let's remove the overrides, so that it doesn't always so up as `INFO` and generate a remediation that users can't do anything with.
/test |
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-aws-ocp4-high |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Code Climate has analyzed commit 0a23020 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5%. View more on Code Climate. |
@rhmdnd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The RHCOS failures are due to unrelated changes in the sysclt rules. The change here was tested:
https://issues.redhat.com/browse/OCPBUGS-19690 is tracking the other RHCOS fixes. |
/packit retest-failed |
/hold for test |
/unhold |
/label qe-approved |
@xiaojiey: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This rule actually has the ability to check the kernel arguments, and
generates a remediation if necessary.
Let's remove the overrides, so that it doesn't always so up as
INFO
and generate a remediation that users can't do anything with.