Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove /dev/shm partition definitions from kickstarts #11535

Merged

Conversation

vojtapolasek
Copy link
Collaborator

Port of #11534 into master branch.

@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. RHEL9 Red Hat Enterprise Linux 9 product related. RHEL7 Red Hat Enterprise Linux 7 product related. CIS CIS Benchmark related. CCN CCN Benchmark related. labels Feb 2, 2024
@vojtapolasek vojtapolasek added this to the 0.1.73 milestone Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Feb 2, 2024

Code Climate has analyzed commit 0fead28 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Feb 2, 2024
@jan-cerny
Copy link
Collaborator

/packit retest-failed

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your removal We have had a similar issue with a /dev/shm recently. We have discovered that if /dev/shm is created by a kickstart then it works in a unattended installation but it breaks GUI installation. The reason was that the fstype tmpfs isn't supported by Anaconda so the GUI checks for it and doesn't have an option for it, but the cmdline most likely lacks this safeguard checks and creates a partition anyway. So I agree with removing these /dev/shms from kickstarts, because they rely on an unsupported feature and undefined behavior.

@jan-cerny jan-cerny merged commit 38094d5 into ComplianceAsCode:master Feb 2, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. CCN CCN Benchmark related. CIS CIS Benchmark related. RHEL7 Red Hat Enterprise Linux 7 product related. RHEL9 Red Hat Enterprise Linux 9 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants