[bugfix] [RHEL/7] Version #2 of service_disabled & service_enabled (unix:file_test based) template for systemd #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 21, 2014 13:05
…st) template for systemd.
Service is considered disabled if:
* corresponding RPM isn't installed OR,
* particular service got masked OR,
* particular service is disabled on boot AND not enabled at runtime.
Also apply that template against abrtd service for testing.
…t) template for systemd.
Service is considered enabled if:
* corresponding RPM is installed AND,
* service in question is not masked AND,
* service in question is enabled on boot time [*].
Also apply that template against iptables service for testing.
[*] It's not needed to check if service isn't disabled at runtime, and
simultaneously enabled on boot time, since this configuration is
unreachable.
iankko
added
bugfix
|
Can the |
|
@redhatrises - yes, that should be done for code cleanup. i've created a tracking ticket to update the shared variables: and will go ahead and merge this in order to meet the fri code freeze |
shawndwells
added a commit
that referenced
this pull request
Sep 25, 2014
[bugfix] [RHEL/7] Version #2 of service_disabled & service_enabled (unix:file_test based) template for systemd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset updates the original version it to be able to properly handle also cases, when service is masked or enabled-runtime.
For service_disabled template - service is considered to be disabled when:
* corresponding RPM isn't installed OR,
* particular service got masked OR,
* particular service is disabled on boot AND not enabled at runtime.
For testing this template is applied against abrtd service (service_abrtd_disabled check).
For service enabled template - service is considered to be enabled when:
* corresponding RPM is installed AND,
* service in question is not masked AND,
* service in question is enabled on boot time
For testing this template has been applied against iptables service (service_iptables_enabled check).
Tested on RHEL-7 & works as expected (AFAICT).
Please review.
Thank you, Jan.