Fix Scrutinizer ssg module issues - #1 #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @cipherboy! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on June 15, 2018 at 17:42 Hours UTC |
mpreisler
reviewed
Jun 15, 2018
ssg/_oval.py
Outdated
| defname = _add_elements(body, header) | ||
| if defname == None: | ||
| print("Error while evaluating oval: defname not set; missing " | ||
| "definitions section?") |
There was a problem hiding this comment.
print this to stderr via file=sys.stderr
cipherboy
force-pushed
the
fix-scrutinizer-ssg-issues-1
branch
2 times, most recently
from
1c01a2a
to
0eb9388
Compare
cipherboy
changed the title
cipherboy
force-pushed
the
fix-scrutinizer-ssg-issues-1
branch
from
0eb9388
to
a565756
Compare
cipherboy
changed the title
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy
force-pushed
the
fix-scrutinizer-ssg-issues-1
branch
from
a565756
to
1d2a0e6
Compare
|
The inspection completed: 38 new issues, 2 updated code elements |
|
Of course they don't show how many issues I fixed. :P
@mpreisler This is ready for a review / merge. |
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
First of PRs to fix various issues that Scrutinizer found during and before the move. All should be relatively minor issues. Also will fix feedback from PEP8 in most cases.