Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing rules for docker and psacct packages installed #4054

Merged
merged 4 commits into from
Mar 6, 2019
Merged

Add missing rules for docker and psacct packages installed #4054

merged 4 commits into from
Mar 6, 2019

Conversation

jan-cerny
Copy link
Collaborator

Description:

  • Create rule package_docker_installed and add it to the profile where service_docker_enabled is included.
  • Create rule package_psacct_installed and add it to all profiles where service_psacct_enabled is included.
  • Remove docker rules form RHEL8 benchmark because Docker isn't available on RHEL8.

Rationale:

  • Ansible remediation for rule service_docker_enabled fails because the service docker was not found because package docker was not installed.
  • Ansible remediation for rule service_psacct_enabled fails because the service psacct was not found because package psacct was not installed.

@jan-cerny
Add rule package_docker_installed
6b9120f 
There is a rule service_docker_enabled, but the Ansible remediation
for this rule failed, because there was no rule that contained
an Ansible task to install the Docker package.
@jan-cerny
Remove Docker rules from RHEL8 Benchmark
bdcbb9b 
Docker isn't available on RHEL8.
@jan-cerny
Add rule package_docker_installed to Docker host profile
9d20a9f
@jan-cerny
Add rule package_psacct_installed
b34bdcf 
There is a rule service_psacct_enabled, but the Ansible remediation
for this rule failed, because there was no rule that contained
an Ansible task to install the psacct package.
Also adds the rule package_psacct_installed to all profiles
where rule service_psacct_enabled is included.
@jan-cerny jan-cerny added bugfix Fixes to reported bugs. RHEL Red Hat Enterprise Linux product related. Docker SSG profile Ansible Ansible remediation update. labels Mar 5, 2019
@jan-cerny jan-cerny added this to the 0.1.44 milestone Mar 5, 2019
@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues

@yuumasato yuumasato self-assigned this Mar 6, 2019
@yuumasato
Copy link
Member

LGTM.

@yuumasato yuumasato merged commit 57510f8 into ComplianceAsCode:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yuumasato yuumasato

Labels
Ansible Ansible remediation update. bugfix Fixes to reported bugs. RHEL Red Hat Enterprise Linux product related.
Projects
None yet
Milestone
0.1.44
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jan-cerny @scrutinizer-notifier @yuumasato