Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added provisional remediation to audit rules. #4107

Merged
merged 1 commit into from Mar 11, 2019

Conversation

matejak
Copy link
Member

@matejak matejak commented Mar 11, 2019

The remediation copies part of the recommended audit config that should assure OSPP compliance.

Disadvantage: The remediation fixes more than one rule at time.

Advantage: This is the way how to fix the issue from the audit project's point of view + we can guarantee related audit rule ordering.

@matejak matejak added the Bash Bash remediation update. label Mar 11, 2019
@yuumasato
Copy link
Member

@matejak I know there aren't merge conflicts, but when I scan and remediate, some rules that should be passing are failing.
To clear out the doubt whether the failures are due to outdated master or current issues, can you please rebase on top of latest master?

@matusmarhefka
Copy link
Member

@yuumasato Yes, the branch is not updated and is missing some important commits from the master.

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

@yuumasato
Copy link
Member

yuumasato commented Mar 11, 2019

For some reason, the report of the remediation run fails on rules:

  • audit_rules_unsuccessful_file_modification_open_rule_order
  • audit_rules_unsuccessful_file_modification_openat_rule_order
  • audit_rules_unsuccessful_file_modification_open_by_handle_at_rule_order

But on second scan, these rules pass.

Edit: copy paste error

@matusmarhefka
Copy link
Member

We need to add remediations also for:

  • audit_rules_unsuccessful_file_modification_open_rule_order
  • audit_rules_unsuccessful_file_modification_openat_rule_order
  • audit_rules_unsuccessful_file_modification_open_by_handle_at_rule_order

The remediation copies part of the recommended audit config that should assure OSPP compliance.
Disadvantage: The remediation fixes more than one rule at time.
Advantage: This is the way how to fix the issue from the audit project's point of view + we can guarantee related audit rule ordering.
@matejak
Copy link
Member Author

matejak commented Mar 11, 2019

Rebased, changed according to input.

@scrutinizer-notifier
Copy link

The inspection completed: 3 new issues

@matusmarhefka
Copy link
Member

All the audit rules are passing after the latest updates 🙂

@matejak matejak marked this pull request as ready for review March 11, 2019 14:24
@matusmarhefka
Copy link
Member

@matejak Good job, thank you.

@matusmarhefka matusmarhefka merged commit 0ec27ba into ComplianceAsCode:master Mar 11, 2019
@yuumasato
Copy link
Member

Also ACK, I understand the solution is not ideal, and these remediations should be improved in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants