Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force frequent session key renegotiation. #4711

Merged
merged 2 commits into from Aug 13, 2019

Conversation

adelton
Copy link
Collaborator

@adelton adelton commented Aug 12, 2019

Description:

  • Force frequent session key renegotiation.

Rationale:

  • By decreasing the limit based on the amount of data and enabling time-based limit, effects of potential attacks against encryption keys are limited.

@adelton
Copy link
Collaborator Author

adelton commented Aug 12, 2019

The OVAL check does not seem to work for this value which has space in it.

The generated XML is

        <ns7:textfilecontent54_object id="oval:ssg-obj_sshd_rekey_limit:obj:1" version="1">
          <ns7:filepath>/etc/ssh/sshd_config</ns7:filepath>
          <ns7:pattern operation="pattern match">^[ \t]*(?i)RekeyLimit(?-i)[ \t]+(\S*)[ \t]*(?:|(?:#.*))?$</ns7:pattern>
          <ns7:instance datatype="int" operation="greater than or equal">1</ns7:instance>
        </ns7:textfilecontent54_object>

so the matched value is expected to be (\S*).

@adelton
Copy link
Collaborator Author

adelton commented Aug 12, 2019

Addressed in e4e1c82.

@jan-cerny jan-cerny self-assigned this Aug 13, 2019
@jan-cerny jan-cerny added this to the 0.1.46 milestone Aug 13, 2019
@jan-cerny jan-cerny merged commit 04020fc into ComplianceAsCode:master Aug 13, 2019
@jan-cerny
Copy link
Collaborator

now it matches for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants