Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Network Policies rule to OCP #4934

Merged
merged 1 commit into from Nov 12, 2019
Merged

Add Network Policies rule to OCP #4934

merged 1 commit into from Nov 12, 2019

Conversation

redhatrises
Copy link
Contributor

@redhatrises redhatrises commented Oct 17, 2019 •
edited

@redhatrises redhatrises added the OpenShift OpenShift product related. label Oct 17, 2019
@redhatrises redhatrises added this to the 0.1.47 milestone Oct 17, 2019
shawndwells
shawndwells suggested changes Oct 22, 2019
View reviewed changes
Copy link
Member

@shawndwells shawndwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the description and ocil, it was not immediately clear an administrator could choose either plugin. Could the description be updated to clearly state this?

@redhatrises
Copy link
Contributor Author

Reading the description and ocil, it was not immediately clear an administrator could choose either plugin. Could the description be updated to clearly state this?

@shawndwells updated to reflect that the Kubernetes NetworkPlugin should be chosen over the Multi-tenant plugin.

@yuumasato yuumasato modified the milestones: 0.1.47, 0.1.48 Nov 5, 2019
shawndwells
shawndwells approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@shawndwells shawndwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Thanks for the updates!

@shawndwells shawndwells merged commit 0854bd0 into ComplianceAsCode:master Nov 12, 2019
@redhatrises redhatrises deleted the ocp_updates branch November 12, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawndwells shawndwells shawndwells approved these changes

Assignees

@shawndwells shawndwells

Labels
OpenShift OpenShift product related.
Projects
None yet
Milestone
0.1.48
Development

Successfully merging this pull request may close these issues.

Configure Network policies as appropriate
3 participants
@redhatrises @shawndwells @yuumasato