New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OVAL applicability for RHV4 #5053
Fix OVAL applicability for RHV4 #5053
Conversation
Wrong guide would case the products of the rule to be empty
a89f4e7
to
84a143a
Compare
Rebased after merge of #5049 |
The rule.yaml's already have the prodtype rhv4.
These were missed by utils/rule_dir_json.py utils/rule_dir_stats.py and utils/mod_checks.py
These rules are templated and the OVAL checks are referenced as extended_definitions.
84a143a
to
7ecc493
Compare
There were a few OVAL checks which already had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on statistics jenkins job and comparing some data around. I discovered that the OVAL from rule: https://github.com/ComplianceAsCode/content/tree/master/linux_os/guide/system/permissions/restrictions/enable_nx/install_PAE_kernel_on_x86-32 should be updated
Where? What do you mean? |
OMG, I mixed pull requests. I meant the issue on remediation applicability from #5056. Please disregard this request. I will update |
Nice catch, the |
Description:
prodtype: rhv4
applicable torhv4
Rationale:
prodtype: rhv4
just enables part of the content. A lot of rules are evaluating tonotchecked
.Notes:
Most of the
<platform>Red Hat Virtualization 4</platform>
was added viautils/mod_checks.py
.The process was as follows:
Processed rhv_oval.txt attached.