Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regex in accounts_passwords_pam_faillock_deny #5166

Merged

Conversation

vojtapolasek
Copy link
Collaborator

Description:

oval is updated to ignore mentions of pam_unix in commented lines
test is updated to showcase that it works also for inline comments

Rationale:

In case some comment contained string "pam_unix", a rule might have been evaulated as passed although the PAM configuration was not correct.

oval is updated to ignore mentions of pam_unix in commented lines
@jan-cerny jan-cerny self-assigned this Feb 5, 2020
@jan-cerny jan-cerny added this to the 0.1.49 milestone Feb 5, 2020
@jan-cerny
Copy link
Collaborator

@vojtapolasek Thanks, nice catch!

@jan-cerny jan-cerny merged commit f8dc6a9 into ComplianceAsCode:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants