Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PCRE_ERROR_MATCHLIMIT in PASS_MAX_DAYS #6099

Merged
merged 1 commit into from Sep 18, 2020
Merged

Fix PCRE_ERROR_MATCHLIMIT in PASS_MAX_DAYS #6099

merged 1 commit into from Sep 18, 2020

Conversation

yuumasato
Copy link
Member

Description:

  • Fix memory limit match error when scanning an actual /etc/login.defs
    file, which is much larger than the test files.
  • Removed the single line behavior and added tests to check whether it is
    matching the last PASS_MAX_DAYS.

Rationale:

@yuumasato
Fix PCRE_ERROR_MATCHLIMIT in PASS_MAX_DAYS
e506029 
Fix memory limit match error when scanning an actual /etc/login.defs
file, which is much larger than the test files.

Removed the single line behavior and added tests to check whether it is
mathing the last PASS_MAX_DAYS.
@yuumasato yuumasato added the bugfix Fixes to reported bugs. label Sep 17, 2020
@yuumasato yuumasato added this to the 0.1.53 milestone Sep 17, 2020
@mildas
Copy link
Contributor

mildas commented Sep 17, 2020

Changes identified:
Rule accounts_maximum_age_login_defs:
 Text changed in OVAL check.
 Node deleted from OVAL check.
 Deleted attribute from OVAL check.

Recommended tests to execute:
 build_product fedora
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using bash --datastream build/ssg-fedora-ds.xml accounts_maximum_age_login_defs

@openshift-ci-robot
Copy link
Collaborator

@yuumasato: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-rhcos4-moderate e506029 link /test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vojtapolasek vojtapolasek self-assigned this Sep 18, 2020
@vojtapolasek
Copy link
Collaborator

LGTM, thank you.

@vojtapolasek vojtapolasek merged commit 44ecfdf into ComplianceAsCode:master Sep 18, 2020
vojtapolasek added a commit that referenced this pull request Sep 18, 2020
@vojtapolasek
Merge pull request #6099 from yuumasato/accounts_maximum_age_login_de…
35dc212 
…fs_pcre_error-8

Fix PCRE_ERROR_MATCHLIMIT in PASS_MAX_DAYS

(cherry picked from commit 44ecfdf)
@yuumasato yuumasato deleted the accounts_maximum_age_login_defs_pcre_error-8 branch September 18, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vojtapolasek vojtapolasek

Labels
bugfix Fixes to reported bugs.
Projects
None yet
Milestone
0.1.53
Development

Successfully merging this pull request may close these issues.

Scan of rule accounts_maximum_age_login_defs results in unknown
4 participants
@yuumasato @mildas @openshift-ci-robot @vojtapolasek