ocp4: Use ScanSettingBindings for e2e tests #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test e2e-aws-ocp4-cis-node |
|
Pull-request updated, HEAD is now dd56b9d |
jhrozek
reviewed
Oct 26, 2020
| err := backoff.RetryNotify(func() error { | ||
| return ctx.dynclient.Create(goctx.TODO(), binding) | ||
| }, bo, func(err error, d time.Duration) { | ||
| fmt.Printf("Couldn't create binding after %s: %s\n", d.String(), err) |
There was a problem hiding this comment.
Is %s OK to use for formatting an error? I've usually seen %v being used.
There was a problem hiding this comment.
Hmm, git grep across some code shows it is, please disregard.
These are the objects we recommend folks to use instead of raw ComplianceSuites. It also allows us for auto-detection of platform/node checks.
|
Pull-request updated, HEAD is now 5a26d84 |
|
/test e2e-aws-rhcos4-e8 |
|
/test all |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the objects we recommend folks to use instead of raw
ComplianceSuites. It also allows us for auto-detection of platform/node
checks.