Introduce packit support #6649

matejak · 2021-03-01T16:25:14Z

Packit enables integration with downstream Fedora packaging, and potentially with packaging of derived systems.

The setup uses the Rawhide spec file to create the srpm, so the upstream project doesn't require any adjustments.

TomasTomecek

I can see the SRPM build failed due to infra problem - I'll investigate tomorrow what the problem was.

TomasTomecek · 2021-03-01T16:55:53Z

.packit.yaml

+# add or remove files that should be synced
+synced_files:
+    - scap-security-guide.spec
+    - .packit.yaml


these are actually defaults, so you can drop these 4 lines if you want

TomasTomecek · 2021-03-01T16:58:17Z

.packit.yaml

+downstream_package_name: scap-security-guide
+
+actions:
+  post-upstream-clone: "wget https://src.fedoraproject.org/rpms/scap-security-guide/raw/rawhide/f/scap-security-guide.spec -O scap-security-guide.spec"


happy to see this! I hope that you don't change dependencies often so that you don't run into "I need to fix the spec in downstream in order to have passing builds in the upstream"

This won't be a problem here - required dependencies don't change often.

JAORMX · 2021-03-01T18:12:01Z

/retest

TomasTomecek · 2021-03-01T18:12:26Z

okay, I can see the problem now, we failed to pull image from docker.io due to quota; sorry about that

TomasTomecek · 2021-03-01T18:12:33Z

/packit build

TomasTomecek · 2021-03-02T08:09:28Z

I can see the RPM failed to be built due to cmake - is there some special way to create archives or doing git archive is good enough?

jan-cerny · 2021-03-02T08:47:49Z

@TomasTomecek Only the F32 build fails. For some reason it tries to use the Rawhide spec file on F32. Do you have any ideas why it didn't use the F32 spec file on F32?

jan-cerny · 2021-03-02T08:52:25Z

Aha I can see what can be the problem, it's in the pull request description:

The setup uses the Rawhide spec file to create the srpm, so the upstream project doesn't require any adjustments.

You can't use the Rawhide spec file to build RPM on F32 because we use CMake and the RPM macro %cmake behaves differently starting from F33.

If you are curious you can read details about this F33 change: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds

@matejak Please change your "setup" so that a correct spec according to the Fedora version is used.

matejak · 2021-03-02T09:47:58Z

@matejak Please change your "setup" so that a correct spec according to the Fedora version is used.

That's not a bug, it's a feature - the point is to use the Rawhide spec file for everything. You are right that it doesn't work for Fedora 32, and it also doesn't work for RHEL8 due to the cmake build issue as well, but it will work for anything newer than Fedora 33 and derived.

@TomasTomecek could you please suggest the most elegant way how to disable Packit builds for F32?

jan-cerny · 2021-03-02T10:10:14Z

@matejak Please change your "setup" so that a correct spec according to the Fedora version is used.

That's not a bug, it's a feature - the point is to use the Rawhide spec file for everything. You are right that it doesn't work for Fedora 32, and it also doesn't work for RHEL8 due to the cmake build issue as well, but it will work for anything newer than Fedora 33 and derived.

I think that maybe you can add an if else construction that depend on the system version to the rawhide spec

matejak · 2021-03-02T16:43:01Z

I think that maybe you can add an if else construction that depend on the system version to the rawhide spec

I don't think that a product that will be EOLed in two months deserves to have an if statement in the rawhide spec file. The goal is to have the rawhide spec file as simple as possible as long as it can be used on RHEL, CentOS Stream, and Fedora at the same time. If there is a conflict between simplicity and product support, one has to pick sides, and F32 alone is not a convincing side.

TomasTomecek · 2021-03-02T17:03:34Z

The easiest solution is to configure jobs and precisely pick chroots:

jobs:
  - job: copr_build
    trigger: pull_request
    metadata:
      targets:
        - fedora-rawhide
        - fedora-34
        - fedora-33
  - job: tests
    trigger: pull_request
    metadata:
      targets:
        - fedora-rawhide
        - fedora-34
        - fedora-33

we also have aliases for development and stable versions of Fedora Linux: https://packit.dev/docs/configuration/#available-copr-build-targets

Let me know if this is acceptable for you.

jan-cerny · 2021-03-05T08:00:48Z

.packit.yaml

+  post-upstream-clone: "wget https://src.fedoraproject.org/rpms/scap-security-guide/raw/rawhide/f/scap-security-guide.spec -O scap-security-guide.spec"
+
+
+# TODO: Remove the "jobs" key as soon as F34 is out


My understanding was that this key disables F32 builds so I would say that it should be disabled after F32 is removed from the infrastructure. Am I correct or are you correct?

Also, is F33 under fedora-development?

I think that both of us are correct - when F34 is released, F32 will disappear, and we can return to default jobs.

F33 is clearly not a development version, as you can see when you check out test results. I have tried to avoid mentioning explicit version numbers, so things work even if nobody removes the jobs key.

openshift-ci · 2021-06-21T11:29:21Z

@matejak: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-ocp4-e8	`9b9eaee`	link	`/test e2e-aws-ocp4-e8`
ci/prow/e2e-aws-ocp4-cis	`9b9eaee`	link	`/test e2e-aws-ocp4-cis`
ci/prow/e2e-aws-rhcos4-e8	`9b9eaee`	link	`/test e2e-aws-rhcos4-e8`
ci/prow/e2e-aws-ocp4-cis-node	`9b9eaee`	link	`/test e2e-aws-ocp4-cis-node`
ci/prow/e2e-aws-rhcos4-moderate	`9b9eaee`	link	`/test e2e-aws-rhcos4-moderate`
ci/prow/e2e-aws-ocp4-moderate-node	`9b9eaee`	link	`/test e2e-aws-ocp4-moderate-node`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jan-cerny · 2021-09-15T07:26:09Z

@matejak Any updates?

matejak · 2021-09-23T07:57:26Z

I would say that it simply works, so we can merge it. If we wait until the F34 release, we can simplify the config even further.

jan-cerny · 2021-09-23T09:16:53Z

@matejak Fedora 34 was released in April

The setup uses the Rawhide spec file to create an srpm.

matejak · 2021-09-23T09:30:11Z

@matejak Fedora 34 was released in April

Time flies, it's actually really F35 which is around the corner

matejak · 2021-09-23T09:33:31Z

And it doesn't work because of patches in the Fedora spec file, so let's close the PR.

matejak added this to the 0.1.55 milestone Mar 1, 2021

matejak changed the title ~~Introduced packit support.~~ Introduce packit support Mar 1, 2021

TomasTomecek reviewed Mar 1, 2021

View reviewed changes

matejak force-pushed the packit branch from a94744c to 9b9eaee Compare March 3, 2021 10:10

jan-cerny reviewed Mar 5, 2021

View reviewed changes

vojtapolasek modified the milestones: 0.1.55, 0.1.56 Mar 8, 2021

vojtapolasek modified the milestones: 0.1.56, 0.1.57 May 11, 2021

matejak modified the milestones: 0.1.57, 0.1.58 Aug 17, 2021

yuumasato modified the milestones: 0.1.58, 0.1.59 Sep 15, 2021

Introduced packit support.

cbbbbb7

The setup uses the Rawhide spec file to create an srpm.

matejak force-pushed the packit branch from 9b9eaee to cbbbbb7 Compare September 23, 2021 09:29

matejak closed this Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce packit support #6649

Introduce packit support #6649

matejak commented Mar 1, 2021

TomasTomecek left a comment

TomasTomecek Mar 1, 2021

TomasTomecek Mar 1, 2021

matejak Mar 2, 2021

JAORMX commented Mar 1, 2021

TomasTomecek commented Mar 1, 2021

TomasTomecek commented Mar 1, 2021

TomasTomecek commented Mar 2, 2021

jan-cerny commented Mar 2, 2021

jan-cerny commented Mar 2, 2021

matejak commented Mar 2, 2021 •

edited

jan-cerny commented Mar 2, 2021

matejak commented Mar 2, 2021

TomasTomecek commented Mar 2, 2021 •

edited

jan-cerny Mar 5, 2021

jan-cerny Mar 5, 2021

matejak Mar 5, 2021

openshift-ci bot commented Jun 21, 2021

jan-cerny commented Sep 15, 2021

matejak commented Sep 23, 2021

jan-cerny commented Sep 23, 2021

matejak commented Sep 23, 2021

matejak commented Sep 23, 2021

		post-upstream-clone: "wget https://src.fedoraproject.org/rpms/scap-security-guide/raw/rawhide/f/scap-security-guide.spec -O scap-security-guide.spec"


		# TODO: Remove the "jobs" key as soon as F34 is out

Introduce packit support #6649

Introduce packit support #6649

Conversation

matejak commented Mar 1, 2021

TomasTomecek left a comment

Choose a reason for hiding this comment

TomasTomecek Mar 1, 2021

Choose a reason for hiding this comment

TomasTomecek Mar 1, 2021

Choose a reason for hiding this comment

matejak Mar 2, 2021

Choose a reason for hiding this comment

JAORMX commented Mar 1, 2021

TomasTomecek commented Mar 1, 2021

TomasTomecek commented Mar 1, 2021

TomasTomecek commented Mar 2, 2021

jan-cerny commented Mar 2, 2021

jan-cerny commented Mar 2, 2021

matejak commented Mar 2, 2021 • edited

jan-cerny commented Mar 2, 2021

matejak commented Mar 2, 2021

TomasTomecek commented Mar 2, 2021 • edited

jan-cerny Mar 5, 2021

Choose a reason for hiding this comment

jan-cerny Mar 5, 2021

Choose a reason for hiding this comment

matejak Mar 5, 2021

Choose a reason for hiding this comment

openshift-ci bot commented Jun 21, 2021

jan-cerny commented Sep 15, 2021

matejak commented Sep 23, 2021

jan-cerny commented Sep 23, 2021

matejak commented Sep 23, 2021

matejak commented Sep 23, 2021

matejak commented Mar 2, 2021 •

edited

TomasTomecek commented Mar 2, 2021 •

edited