New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new rules to sle12/profiles/stig.profile #6665
Add new rules to sle12/profiles/stig.profile #6665
Conversation
Changes identified: Show detailsRule banner_etc_gdm_banner: Recommended tests to execute: |
Hi @brett060102. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7c65ead
to
e52edae
Compare
Add new rules to sle12/profiles/stig.profile This adds all rules in last PR sle12 stig.profile Fix banner oval check: Appropriately encode GDM banner (ComplianceAsCode#255) The OVAL check doesn't allow the banner text to be in single quote so use the approprate macro to format it correctly. Add pam bash remediation: shared/bash_remediation_functions/ensure_pam_module_options.sh was omitted when pam support was added.
e52edae
to
0b9492a
Compare
@brett060102 I think now is a good time to update the stig_overlay.xml. Check the reference: https://complianceascode.readthedocs.io/en/latest/manual/developer/04_updating_reference_and_overlay.html?highlight=create-stig-overlay#stig-overlay-content |
@ggbecker thank you @abergmann do you want to take this one or shall I? |
This adds all rules in last PR sle12 stig.profile
Fix banner oval check:
Appropriately encode GDM banner
The OVAL check doesn't allow the banner text to be in single quote
so use the approprate macro to format it correctly.
Add missing bash remediation.
Description:
Rationale:
Add newly supported sle12 rules to stig.profile
Add shared/bash_remediation_functions/ensure_pam_module_options.sh which was dropped from earlier changes.
banner oval check: Appropriately encode GDM banner. The OVAL check doesn't allow the banner text to be in single quote so use the appropriate macro to format it correctly.