New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for SUSE SLE-15 #6666
Initial support for SUSE SLE-15 #6666
Conversation
Hi @brett060102. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes identified: Show detailsRule susefirewall2_ddos_protection: Recommended tests to execute: |
Enable development for SUSE SLE-15
cd06acb
to
3bceb64
Compare
@ggbecker Hate to ping you on this one, but is there an issue with it that I am missing above? |
I don't think so. But as a suggestion, I would enable the STIG table and add the STIG id for this one rule you are adding to create a proof of concept. See this PR: https://github.com/ComplianceAsCode/content/pull/6513/files I have also noticed that |
@ggbecker thank you and will do. |
In response to review comments: Update SLE12 and SLE15 CMakeLists.txt to generate stig stable. Update installed_OS_is_vendor_supported/rule.yml to enable sle15
@ggbecker Updated and I hope I followed the desired process this time. |
You still have to include the stig_overlay file. Check how to generate it here: https://complianceascode.readthedocs.io/en/latest/manual/developer/04_updating_reference_and_overlay.html?highlight=create-stig-overlay#stig-overlay-content |
@ggbecker sorry, I had tagged that as separate task. OK to do that for bothe sle12 and sle15 in this review? Do you know why the CaC Jenkins build and unit tests failed? It is not related right. |
May have figured out test failure. |
So, I've added a couple of commits to the pull request. Mainly it was missing the stig_overlay.xml files and there was an issue with one of the xslt files, see: 988e841 I think it should be ok now. |
@ggbecker Thank you very much. And I can now build the overlays as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggbecker changes look great to me. Not approving, since that would mean approving my own changes as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be ok. Let's merge it. Any further issues can be resolved in future PRs.
@ggbecker Thank you. |
Enable development for SUSE SLE-15
Description:
Rationale: