Ignore trailing whitespaces in the unique references test #6702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
approved these changes
Mar 15, 2021
yuumasato
approved these changes
Mar 15, 2021
linux_os/guide/system/network/network-uncommon/kernel_module_dccp_disabled/rule.yml
Outdated
Show resolved
Hide resolved
|
I'm going to remove the commit used for testing purposes. |
ggbecker
force-pushed
the
ignore-trailing-whitespace
branch
from
f0313c0
to
7d304d8
Compare
|
@ggbecker: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Trailing whitespaces could mask duplicated content in the references section
Fixes assert_reference_unique.sh does not discard trailing spaces #6697
The commit f0313c0 is solely for testing purposes to check that the code works. After the PR is approved the commit will be stripped away.