ocp4: Add relevant description for protectKernelDefaults rule #6705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
requested review from
mrogers950 and
jhrozek
and removed request for
mrogers950
|
Changes identified: Show detailsProfile cis-node on ocp4: Recommended tests to execute: |
JAORMX
changed the title
|
/test e2e-aws-ocp4-e8 |
|
/test e2e-aws-ocp4-cis-node |
mrogers950
reviewed
Mar 16, 2021
applications/openshift/kubelet/kubelet_enable_protect_kernel_defaults/rule.yml
Outdated
Show resolved
Hide resolved
JAORMX
force-pushed
the
ocp4-protectkerneldefaults
branch
2 times, most recently
from
82e07ae
to
edf7a4a
Compare
|
/lgtm |
This adds extra instructions that folks should follow before trying to enable that parameter. Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
JAORMX
force-pushed
the
ocp4-protectkerneldefaults
branch
from
edf7a4a
to
ec92251
Compare
|
@JAORMX: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds extra instructions that folks should follow before trying to
enable that parameter.
Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com