New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLES-15-020101 add rule and tests, no remediation. #6734
Conversation
Hi @brett060102. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes identified: Show detailsRule sudo_restrict_privilege_elevation_to_authorized: Recommended tests to execute: |
linux_os/guide/system/software/sudo/sudo_restrict_privilege_elevation_to_authorized/rule.yml
Outdated
Show resolved
Hide resolved
…evation_to_authorized/rule.yml Co-authored-by: Gabriel Becker <ggasparb@redhat.com>
linux_os/guide/system/software/sudo/sudo_restrict_privilege_elevation_to_authorized/rule.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good if jinja macros from macros-oval.jinja could be leveraged, but it's not that easy to find the right ones and maybe they don't apply straightforward. You could at least create a jinja macro to handle both criteria similar as it's done in: dconf_db_up_to_date
linux_os/guide/system/software/sudo/sudo_restrict_privilege_elevation_to_authorized/rule.yml
Outdated
Show resolved
Hide resolved
…evation_to_authorized/rule.yml Co-authored-by: Gabriel Becker <ggasparb@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks for addressing the requests
Description:
Rationale: