Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLES-15-020101 add rule and tests, no remediation. #6734

Merged
merged 5 commits into from Mar 26, 2021

Conversation

brett060102
Copy link
Contributor

Description:

  • SLES-15-020101 add rule and tests, no remediation.

Rationale:

  • Add SLE-15 specific stigs

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Used by openshift-ci bot. label Mar 22, 2021
@openshift-ci-robot
Copy link
Collaborator

Hi @brett060102. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openscap-ci
Copy link
Collaborator

openscap-ci commented Mar 22, 2021

Changes identified:
Rules:
 sudo_restrict_privilege_elevation_to_authorized
Profiles:
 stig on sle15

Show details

Rule sudo_restrict_privilege_elevation_to_authorized:
 OVAL check is newly added.
Profile stig on sle15:
 Rule sudo_restrict_privilege_elevation_to_authorized added to stig profile.

Recommended tests to execute:
 build_product sle15
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using bash --datastream build/ssg-sle15-ds.xml sudo_restrict_privilege_elevation_to_authorized
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-sle15-ds.xml stig

…evation_to_authorized/rule.yml

Co-authored-by: Gabriel Becker <ggasparb@redhat.com>
@ggbecker ggbecker self-assigned this Mar 23, 2021
Copy link
Member

@ggbecker ggbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if jinja macros from macros-oval.jinja could be leveraged, but it's not that easy to find the right ones and maybe they don't apply straightforward. You could at least create a jinja macro to handle both criteria similar as it's done in: dconf_db_up_to_date

…evation_to_authorized/rule.yml

Co-authored-by: Gabriel Becker <ggasparb@redhat.com>
Copy link
Member

@ggbecker ggbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks for addressing the requests

@ggbecker ggbecker merged commit da57b9e into ComplianceAsCode:master Mar 26, 2021
@yuumasato yuumasato added this to the 0.1.56 milestone Mar 29, 2021
@brett060102 brett060102 deleted the SLES-15-020101 branch June 28, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants