Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the RHEL9 product #6801

Merged
merged 2 commits into from Apr 8, 2021
Merged

Add the RHEL9 product #6801

merged 2 commits into from Apr 8, 2021

Conversation

matejak
Copy link
Member

@matejak matejak commented Apr 7, 2021

RHEL9 will come one day, so it is better to be prepared.

The product has been created using RHEL8 as a basis, and making sure that the build works.
No profiles or STIG overlay for the time being.

@matejak matejak added this to the 0.1.56 milestone Apr 7, 2021
@openscap-ci
Copy link
Collaborator

openscap-ci commented Apr 7, 2021

Changes identified:
Rules:
 checks
Profiles:
 pci-dss on rhel9
Others:
 Changes in Python files.

Show details

Rule checks:
 OVAL check is newly added.
 The rule doesn't occur in any profile nor product.
Profile pci-dss on rhel9:
 Newly added profile.
Others:
 Python abstract syntax tree change found in ssg/constants.py.

Recommended tests to execute:
 (cd build && cmake ../ && ctest -j4)
 build_product rhel9
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-rhel9-ds.xml pci-dss

@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2021

@matejak: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ocp4-cis-node 9502e2b link /test e2e-aws-ocp4-cis-node
ci/prow/e2e-aws-ocp4-moderate 9502e2b link /test e2e-aws-ocp4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error when trying to build:

-- Build files have been written to: /home/wsato/git/content/build
make[2]: *** No rule to make target '../rhel9/profiles', needed by 'rhel9/profiles'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:1319: rhel9/CMakeFiles/generate-internal-rhel9-shorthand.xml.dir/all] Error 2
make: *** [Makefile:171: all] Error 2

I also noticed that CI didn't build the RHEL9 product, is that intended?

rhel9/product.yml Show resolved Hide resolved
RHEL9 will come one day, so better to be prepared.
The product has been created using RHEL8 as a basis, and making sure that the build works.
No profiles or STIG overlay for the time being.
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> I also noticed that CI didn't build the RHEL9 product, is that intended?

Discussed this with @matejak and enabling build and test of it right now will impact currently open PRs. So this can be enabled in the short term future to minimize impact on others.

Edit: sorry for wrong mention.

@yuumasato yuumasato self-assigned this Apr 8, 2021
@yuumasato yuumasato merged commit fd34850 into ComplianceAsCode:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants