Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHCOS4: Add relevant instructions and e2e test for banner_etc_issue #6827

Merged
merged 1 commit into from Apr 15, 2021
Merged

RHCOS4: Add relevant instructions and e2e test for banner_etc_issue #6827

merged 1 commit into from Apr 15, 2021

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Apr 13, 2021 •
edited

It was missing.

Note that this also changes the OVAL to take /etc/issue.d into account and look for the
legal notice there too.

@JAORMX JAORMX force-pushed the rhcos4-etc-issue branch 7 times, most recently from 5d4f33b to 2319457 Compare April 13, 2021 13:27
@openscap-ci
Copy link
Collaborator

openscap-ci commented Apr 13, 2021 •
edited

Changes identified:
Rules:
 banner_etc_issue

Show details

Rule banner_etc_issue:
 Attribute value changed in OVAL check.
 New node inserted to OVAL check.
 Node deleted from OVAL check.
 Text changed in OVAL check.

Recommended tests to execute:
 build_product rhel8
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using bash --datastream build/ssg-rhel8-ds.xml banner_etc_issue

@JAORMX JAORMX marked this pull request as draft April 13, 2021 16:03
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 13, 2021
@JAORMX
Copy link
Contributor Author

JAORMX commented Apr 13, 2021

/test all

@JAORMX
Copy link
Contributor Author

JAORMX commented Apr 13, 2021

/retest

1 similar comment
@JAORMX
Copy link
Contributor Author

JAORMX commented Apr 13, 2021

/retest

@JAORMX
RHCOS4: Add relevant instructions and e2e test for banner_etc_issue
e5e6cd1 
It was missing.

Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
@JAORMX JAORMX closed this Apr 14, 2021
@JAORMX JAORMX reopened this Apr 14, 2021
@JAORMX JAORMX marked this pull request as ready for review April 14, 2021 09:57
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 14, 2021
@JAORMX
Copy link
Contributor Author

JAORMX commented Apr 14, 2021

/test e2e-aws-rhcos4-e8

@jhrozek
Copy link
Collaborator

jhrozek commented Apr 14, 2021

The E2E tests are failing with:

�[31mERRO�[0m[2021-04-14T12:03:10Z] 'ascii' codec can't encode character '\u2026' in position 87: ordinal not in range(128)

this seems like some python utf8 issue, but we don't use python anywhere in our e2e tests do we? is this coming from prow itself?

jhrozek
jhrozek approved these changes Apr 14, 2021
View reviewed changes
Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself looks good FWIW

@JAORMX
Copy link
Contributor Author

JAORMX commented Apr 14, 2021

/retest

1 similar comment
@JAORMX
Copy link
Contributor Author

JAORMX commented Apr 14, 2021

/retest

@JAORMX JAORMX closed this Apr 14, 2021
@JAORMX JAORMX reopened this Apr 14, 2021
@JAORMX
Copy link
Contributor Author

JAORMX commented Apr 14, 2021

/retest

1 similar comment
@JAORMX
Copy link
Contributor Author

JAORMX commented Apr 15, 2021

/retest

@JAORMX JAORMX merged commit d5fd96c into ComplianceAsCode:master Apr 15, 2021
@yuumasato yuumasato added this to the 0.1.56 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.56
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JAORMX @openscap-ci @jhrozek @yuumasato @openshift-ci-robot