CIS: Add OCIL to kubelet_configure_tls_cipher_suites #6835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
reviewed
Apr 14, 2021
| @@ -21,10 +21,18 @@ severity: medium | |||
| references: | |||
| cis@ocp4: 4.2.13 | |||
|
|
|||
| ocil_clause: "TLS cipher suite configuration is not configured" | |||
| ocil_clause: "TLS cipher suite configuration is not configured or contains insecure ciphers" | |||
There was a problem hiding this comment.
Now that you're here, could you also add a description that indicates how to remediate this? in the description section.
|
@jhrozek: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The rule contained just a placeholder text
|
On Wed, Apr 14, 2021 at 03:49:26AM -0700, Juan Osorio Robles wrote:
@JAORMX commented on this pull request.
> @@ -21,10 +21,18 @@ severity: medium
references:
***@***.***: 4.2.13
-ocil_clause: "TLS cipher suite configuration is not configured"
+ocil_clause: "TLS cipher suite configuration is not configured or contains insecure ciphers"
Now that you're here, could you also add a description that indicates how to remediate this? in the `description` section.
Sure!
|
|
I'm going to merge right away since the patch just adds OCIL and the test that builds the content already passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds an OCIL to kubelet_configure_tls_cipher_suites
Rationale:
The rule contained just a placeholder text