Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL8 - ensuring stigid's and references are set where appropriate #6864

Merged

Conversation

carlosmmatos
Copy link
Contributor

@carlosmmatos carlosmmatos commented Apr 19, 2021

Cleaning up/adding RHEL8 stigid's and other disa refs.

I understand that we will have some duplicate STIG ID's, but we'll just have to deal with that for now until we either:

  • Get DISA to update it OR
  • provide a temporary rule that accounts for the multiple rules

@openshift-ci-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 19, 2021
@carlosmmatos carlosmmatos changed the title Ensuring stigid's are set where appropriate RHEL8 - ensuring stigid's are set where appropriate Apr 20, 2021
@carlosmmatos carlosmmatos marked this pull request as ready for review April 20, 2021 15:12
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 20, 2021
@carlosmmatos
Copy link
Contributor Author

@ggbecker - I know we talked about the issues with having duplicate stigid's but what is the current alternative to this approach? Is it better to exclude a stigid on a rule than to have it duplicated? Should we tackle these as one-off stig rules that combine both?

@carlosmmatos carlosmmatos changed the title RHEL8 - ensuring stigid's are set where appropriate RHEL8 - ensuring stigid's and references are set where appropriate Apr 26, 2021
@carlosmmatos carlosmmatos marked this pull request as ready for review April 28, 2021 14:57
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 28, 2021
@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2021

@carlosmmatos: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-rhcos4-e8 1070325 link /test e2e-aws-rhcos4-e8
ci/prow/e2e-aws-ocp4-cis 1070325 link /test e2e-aws-ocp4-cis
ci/prow/e2e-aws-ocp4-cis-node 1070325 link /test e2e-aws-ocp4-cis-node
ci/prow/e2e-aws-rhcos4-moderate 1070325 link /test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ggbecker ggbecker self-assigned this Apr 29, 2021
@ggbecker ggbecker merged commit 2a8cc96 into ComplianceAsCode:master Apr 29, 2021
@yuumasato yuumasato added this to the 0.1.56 milestone Apr 29, 2021
@marcusburghardt marcusburghardt added RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants