Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rule,Remediation and Test for SLES-15-030760 #6869

Merged
merged 6 commits into from Apr 30, 2021

Conversation

yarunachalam
Copy link
Contributor

Description:

  • Add Rule,Remediation and Test for SLES-15-030760

Rationale:

  • Add SLE15 rule to 'Record Attempts to Alter Process and Session Initiation Information utmp'

@openshift-ci-robot
Copy link
Collaborator

Hi @yarunachalam. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Used by openshift-ci bot. label Apr 20, 2021
@openscap-ci
Copy link
Collaborator

openscap-ci commented Apr 20, 2021

Changes identified:
Rules:
 audit_rules_session_events_utmp
Profiles:
 stig on sle15

Show details

Rule audit_rules_session_events_utmp:
 Ansible remediation newly added.
 Bash remediation is newly added.
Profile stig on sle15:
 Rule audit_rules_session_events_utmp added to stig profile.

Recommended tests to execute:
 build_product sle15
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using ansible --datastream build/ssg-sle15-ds.xml audit_rules_session_events_utmp
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using bash --datastream build/ssg-sle15-ds.xml audit_rules_session_events_utmp
 tests/test_suite.py profile --libvirt qemu:///system test-suite-vm --datastream build/ssg-sle15-ds.xml stig

@vojtapolasek vojtapolasek self-assigned this Apr 23, 2021
@vojtapolasek
Copy link
Collaborator

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 23, 2021
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the rule, please see comments.

@yarunachalam yarunachalam changed the title Add Rule,Remediation and Test for SLES-15-030760 WIP:Add Rule,Remediation and Test for SLES-15-030760 Apr 23, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 23, 2021
@yarunachalam
Copy link
Contributor Author

Making rule WIP while I re-work to address comments.

Remove oval script and use template in rule.
Fix ocil and disa records.
/var/run/utmp -> /run/utmp
@yarunachalam yarunachalam changed the title WIP:Add Rule,Remediation and Test for SLES-15-030760 Add Rule,Remediation and Test for SLES-15-030760 Apr 23, 2021
@yarunachalam
Copy link
Contributor Author

@vojtapolasek - this PR is ready for re-review. I don't have the privilege to remove the "do-not-merge/work-in-progress' label.
Thank you.

Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for changes. Please see review comments, srg and nist also are product independent.
Also you changed the path to the file from /var/run/utmp to /run/utmp in rule description, remediations and checks. But you did not change it in tests, please make them aligned. Thank you.

removed sle15 for srg and nist records.
updated test scripts to align with rule desciription for path file.
@vojtapolasek
Copy link
Collaborator

/retest

@openshift-ci
Copy link

openshift-ci bot commented Apr 30, 2021

@yarunachalam: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ocp4-moderate 4d0ef6c link /test e2e-aws-ocp4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vojtapolasek
Copy link
Collaborator

Thank you, merging. The OCP check is failing but this rule is not affecting OCP.

@vojtapolasek vojtapolasek merged commit 43daabe into ComplianceAsCode:master Apr 30, 2021
@yuumasato yuumasato added this to the 0.1.56 milestone May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Used by openshift-ci bot. ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants