New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rule,Remediation and Test for SLES-15-030760 #6869
Add Rule,Remediation and Test for SLES-15-030760 #6869
Conversation
Hi @yarunachalam. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes identified: Show detailsRule audit_rules_session_events_utmp: Recommended tests to execute: |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the rule, please see comments.
linux_os/guide/system/auditing/auditd_configure_rules/audit_rules_session_events_utmp/rule.yml
Outdated
Show resolved
Hide resolved
linux_os/guide/system/auditing/auditd_configure_rules/audit_rules_session_events_utmp/rule.yml
Outdated
Show resolved
Hide resolved
linux_os/guide/system/auditing/auditd_configure_rules/audit_rules_session_events_utmp/rule.yml
Outdated
Show resolved
Hide resolved
...guide/system/auditing/auditd_configure_rules/audit_rules_session_events_utmp/oval/shared.xml
Outdated
Show resolved
Hide resolved
Making rule WIP while I re-work to address comments. |
Remove oval script and use template in rule. Fix ocil and disa records.
/var/run/utmp -> /run/utmp
@vojtapolasek - this PR is ready for re-review. I don't have the privilege to remove the "do-not-merge/work-in-progress' label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for changes. Please see review comments, srg and nist also are product independent.
Also you changed the path to the file from /var/run/utmp to /run/utmp in rule description, remediations and checks. But you did not change it in tests, please make them aligned. Thank you.
linux_os/guide/system/auditing/auditd_configure_rules/audit_rules_session_events_utmp/rule.yml
Outdated
Show resolved
Hide resolved
linux_os/guide/system/auditing/auditd_configure_rules/audit_rules_session_events_utmp/rule.yml
Outdated
Show resolved
Hide resolved
removed sle15 for srg and nist records. updated test scripts to align with rule desciription for path file.
/retest |
@yarunachalam: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thank you, merging. The OCP check is failing but this rule is not affecting OCP. |
Description:
Rationale: