Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocp4: Enhance group ownership checks openvswitch processes pid files #6914

Merged
merged 1 commit into from Apr 29, 2021

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Apr 29, 2021

In a more recent version of Open vSwitch, the process pid files changed
ownership from "openvswitch" to "hugetlbfs". OCP 4.6 will stay in an
older version of OvS, so to keep this working with newer versions (e.g.
the one included in OCP 4.8), this fixes the content to check for both
groups. This way the content keeps being valid accross releases.

Closes #6913

Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com

@JAORMX JAORMX requested a review from jhrozek April 29, 2021 11:05
@openscap-ci
Copy link
Collaborator

openscap-ci commented Apr 29, 2021

Changes identified:
Rules:
 file_groupowner_ovs_pid
 file_groupowner_ovs_vswitchd_pid
 file_groupowner_ovsdb_server_pid

Show details

Rule file_groupowner_ovs_pid:
 OVAL check is newly added.
Rule file_groupowner_ovs_vswitchd_pid:
 OVAL check is newly added.
Rule file_groupowner_ovsdb_server_pid:
 OVAL check is newly added.

Recommended tests to execute:
 build_product ocp4
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using bash --datastream build/ssg-ocp4-ds.xml file_groupowner_ovs_pid
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using bash --datastream build/ssg-ocp4-ds.xml file_groupowner_ovs_vswitchd_pid
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using bash --datastream build/ssg-ocp4-ds.xml file_groupowner_ovsdb_server_pid

In a more recent version of Open vSwitch, the process pid files changed
ownership from "openvswitch" to "hugetlbfs". OCP 4.6 will stay in an
older version of OvS, so to keep this working with newer versions (e.g.
the one included in OCP 4.8), this fixes the content to check for both
groups. This way the content keeps being valid accross releases.

Closes ComplianceAsCode#6913

Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
@JAORMX JAORMX merged commit b4855c7 into ComplianceAsCode:master Apr 29, 2021
@yuumasato yuumasato added this to the 0.1.56 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCP4 cis-node profile is broken due to openvswitch change
4 participants