Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dconf_gnome_login_retries bash remediation #6999

Conversation

freddieRv
Copy link
Contributor

Description:

  • Missing commas on call to bash_dconf_settings macro resulted in a faulty but executable remediation script, which in turn caused dconf update command to fail

Rationale:

  • This is a bug fix

Missing commas on bash_dconf_settings call resulted
in a faulty but executable remediation script, which
in turn caused "dconf update" command to fail

Signed-off-by: Federico Ramirez <federico.r.ramirez@oracle.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 11, 2021

Hi @freddieRv. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openscap-ci
Copy link
Collaborator

Changes identified:
Rules:
 dconf_gnome_login_retries

Show details

Rule dconf_gnome_login_retries:
 Template usage changed in ansible remediation.

Recommended tests to execute:
 build_product rhel7
 tests/test_suite.py rule --libvirt qemu:///system test-suite-vm --remediate-using bash --datastream build/ssg-rhel7-ds.xml dconf_gnome_login_retries

@vojtapolasek vojtapolasek added the bugfix Fixes to reported bugs. label May 12, 2021
@vojtapolasek vojtapolasek added this to the 0.1.57 milestone May 12, 2021
@jan-cerny jan-cerny self-assigned this May 12, 2021
@jan-cerny jan-cerny merged commit 4fcc590 into ComplianceAsCode:master May 12, 2021
@vojtapolasek vojtapolasek added the backported-into-stabilization PRs which were cherry-picked during stabilization process. label May 14, 2021
@vojtapolasek vojtapolasek modified the milestones: 0.1.57, 0.1.56 May 14, 2021
vojtapolasek pushed a commit that referenced this pull request May 14, 2021
…remediation

Fix dconf_gnome_login_retries bash remediation

(cherry picked from commit 4fcc590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-into-stabilization PRs which were cherry-picked during stabilization process. bugfix Fixes to reported bugs. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants