Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP4: Fix kubelet cert/key matching rules #7152

Merged
merged 1 commit into from Jun 28, 2021

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jun 28, 2021

The location for these changed in OCP 4.9, so this makes it portable.

Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com

@JAORMX JAORMX requested a review from jhrozek June 28, 2021 09:06
Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
code looks good, let's see how CI goes..

The location for these changed in OCP 4.9, so this makes it portable.

Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
@JAORMX
Copy link
Contributor Author

JAORMX commented Jun 28, 2021

Pull-request updated, HEAD is now 745b8a3

@JAORMX
Copy link
Contributor Author

JAORMX commented Jun 28, 2021

Missed a spot

@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2021

@JAORMX: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ocp4-moderate 745b8a3 link /test e2e-aws-ocp4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JAORMX JAORMX merged commit f9c9125 into ComplianceAsCode:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants