Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCP:Fix rule kubelet_enable_streaming_connections #8841

Merged
merged 1 commit into from Jun 15, 2022
Merged

OCP:Fix rule kubelet_enable_streaming_connections #8841

merged 1 commit into from Jun 15, 2022

Conversation

Vincent056
Copy link
Contributor

This PR fix the rule kubelet_enable_streaming_connections, so that it will check the configuration based on variable dynamically.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

@Vincent056
Copy link
Contributor Author

/retest

Mab879
Mab879 requested changes May 27, 2022
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that your files end with a single newline. It looks like there might be some trailing spaces on some of the files in this PR.

@Vincent056
Copy link
Contributor Author

iles end with a single newline. It looks like there might be some trailing spaces on some of the files in this PR.

Thanks for the Review, just fixed that

@Vincent056 Vincent056 requested a review from Mab879 May 27, 2022 18:41
Mab879
Mab879 previously requested changes May 27, 2022
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick respone.

Looks like there are still two files that need the newline at the end.

applications/openshift/kubelet/kubelet_enable_streaming_connections/tests/notmatch.fail.sh Outdated
"shutdownGracePeriod": "0s",
"shutdownGracePeriodCriticalPods": "0s"
}
EOF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need a newline after the EOF.

applications/openshift/kubelet/kubelet_enable_streaming_connections/tests/match.pass.sh Outdated
"shutdownGracePeriod": "5m",
"shutdownGracePeriodCriticalPods": "0s"
}
EOF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need a newline after the EOF.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you help me to review it one more time? thanks @Mab879

@Vincent056
Copy link
Contributor Author

/retest

@Vincent056
OCP:Fix rule kubelet_enable_streaming_connections
d6414ff 
This PR fix the rule kubelet_enable_streaming_connections, so that it will check the configuration based on variable dynamically.
@codeclimate
Copy link

codeclimate bot commented Jun 10, 2022

Code Climate has analyzed commit d6414ff and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 26.1% (0.0% change).

View more on Code Climate.

@Vincent056
Copy link
Contributor Author

/retest

@Vincent056 Vincent056 requested a review from Mab879 June 12, 2022 01:13
jhrozek
jhrozek approved these changes Jun 12, 2022
View reviewed changes
Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I think there was a BZ about this right? If yes, just please remember to mark it as MODIFIED when merging.

@jan-cerny
Copy link
Collaborator

@jhrozek Why didn't you merge it? What is this waiting for?

@Vincent056 Vincent056 dismissed Mab879’s stale review June 15, 2022 08:38

Issue addressed

@Vincent056 Vincent056 merged commit 5279a3f into ComplianceAsCode:master Jun 15, 2022
@jan-cerny jan-cerny added this to the 0.1.63 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

@Mab879 Mab879 Awaiting requested review from Mab879

Assignees

@Vincent056 Vincent056

Labels
None yet
Projects
None yet
Milestone
0.1.63
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vincent056 @jan-cerny @Mab879 @jhrozek