Fix regular expression in Ansible remediation #9063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansible remediation of accounts_umask_etc_profile breaks the /etc/profile syntax because the regex in task "Replace user umask in /etc/profile" is wrong. The regex in ansible.builtin.replace module is considered multiline, it matches everything except hash sign but including newlines, so it "eats" all the lines before the "umask" string if these lines don't contain the hash sign. Fixes: ComplianceAsCode#9053
|
Start a new ephemeral environment with changes proposed in this pull request: |
|
This datastream diff is auto generated by the check Click here to see the full diffansible remediation for rule 'xccdf_org.ssgproject.content_rule_accounts_umask_etc_profile' differs:
--- old datastream
+++ new datastream
@@ -27,8 +27,8 @@
- name: Replace user umask in /etc/profile
ansible.builtin.replace:
path: /etc/profile
- regexp: ^[^#]*umask
- replace: umask {{ var_accounts_user_umask }}
+ regexp: ^(\s*)umask\s+\d+
+ replace: \1umask {{ var_accounts_user_umask }}
tags:
- CCE-81035-8
- DISA-STIG-RHEL-08-020353 |
|
Code Climate has analyzed commit d735420 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 42.7% (0.0% change). View more on Code Climate. |
Mab879
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible remediation of accounts_umask_etc_profile breaks the
/etc/profile syntax because the regex in task "Replace user umask in
/etc/profile" is wrong. The regex in ansible.builtin.replace
module is considered multiline, it matches everything except hash sign
but including newlines, so it "eats" all the lines before the "umask"
string if these lines don't contain the hash sign.
Fixes: #9053