-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove rule accounts_password_minlen_login_defs from RHEL and Fedora profiles #9113
remove rule accounts_password_minlen_login_defs from RHEL and Fedora profiles #9113
Conversation
Code Climate has analyzed commit 0763b1a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 42.7% (0.0% change). View more on Code Climate. |
@vojtapolasek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rules: | ||
- accounts_password_minlen_login_defs | ||
status: automated | ||
status: inherently met |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, RHEL8 doesn't have a default minimum password length of 15 characters...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this control is also enforced by the rule accounts_password_pam_minlen, The variable used in this rule has default value of 15. So do you think the status should be changed back to automated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If rule accounts_password_pam_minlen
needs to be applied then I think this should be set back to automated
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fixing it here: #9125
Description:
Rationale:
The parameter is not used by passwd command in RHEL and FEdora distros.