Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rule accounts_password_minlen_login_defs from RHEL and Fedora profiles #9113

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • remove the rule and associated variable from RHEL and Fedora profiles

Rationale:

The parameter is not used by passwd command in RHEL and FEdora distros.

@vojtapolasek vojtapolasek added Fedora Fedora product related. RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates. RHEL7 Red Hat Enterprise Linux 7 product related. RHEL8 Red Hat Enterprise Linux 8 product related. labels Jul 8, 2022
@vojtapolasek vojtapolasek added this to the 0.1.63 milestone Jul 8, 2022
@vojtapolasek vojtapolasek requested a review from a team as a code owner July 8, 2022 07:13
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@vojtapolasek vojtapolasek changed the title remove rule from RHEL and FEdora profiles remove rule accounts_password_minlen_login_defs from RHEL and Fedora profiles Jul 8, 2022
@codeclimate
Copy link

codeclimate bot commented Jul 8, 2022

Code Climate has analyzed commit 0763b1a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2022

@vojtapolasek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-high 0763b1a link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jan-cerny jan-cerny self-assigned this Jul 8, 2022
@jan-cerny jan-cerny merged commit 41b9020 into ComplianceAsCode:master Jul 8, 2022
rules:
- accounts_password_minlen_login_defs
status: automated
status: inherently met
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, RHEL8 doesn't have a default minimum password length of 15 characters...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this control is also enforced by the rule accounts_password_pam_minlen, The variable used in this rule has default value of 15. So do you think the status should be changed back to automated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If rule accounts_password_pam_minlen needs to be applied then I think this should be set back to automated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fixing it here: #9125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fedora Fedora product related. RHEL7 Red Hat Enterprise Linux 7 product related. RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants