Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the vendor-zipfile and redhat-zipfile targets #9152

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 15, 2022

Description:

Remove the vendor-zipfile and redhat-zipfile cmake targets

Rationale:

RHEL9 and other newer products were not there and since no one
sent in an issue stating they are missing RHEL9, it seems that
no one is using this code, so we should remove it.

@Mab879 Mab879 added the Infrastructure Our content build system label Jul 15, 2022
@Mab879 Mab879 added this to the 0.1.63 milestone Jul 15, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 force-pushed the update_vendor_zip_file_target branch 2 times, most recently from ae71729 to c93d45e Compare July 15, 2022 03:37
CMakeLists.txt Show resolved Hide resolved
RHEL9 and other newer products were not there and since no one
said an issue stating they are missing RHEL9, it seems that
no one is using this code, so we should remove it
@Mab879 Mab879 force-pushed the update_vendor_zip_file_target branch from c93d45e to bbe3178 Compare July 15, 2022 14:02
@Mab879 Mab879 requested a review from jan-cerny July 15, 2022 14:09
@codeclimate
Copy link

codeclimate bot commented Jul 15, 2022

Code Climate has analyzed commit bbe3178 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jul 15, 2022
@jan-cerny jan-cerny merged commit 9c69c5b into ComplianceAsCode:master Jul 15, 2022
@Mab879 Mab879 deleted the update_vendor_zip_file_target branch July 15, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants