Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more sysctl rules to intermediary profile #9202

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

anivan-suse
Copy link
Contributor

Description:

  • Add following rules to ANSSI Intermediary:
    • sysctl_net_ipv4_tcp_syncookies
    • sysctl_net_ipv4_conf_all_send_redirects
    • sysctl_net_ipv4_conf_default_send_redirects
    • sysctl_net_ipv4_ip_forward

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Used by openshift-ci bot. needs-ok-to-test Used by openshift-ci bot. labels Jul 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2022

Hi @anivan-suse. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@anivan-suse anivan-suse marked this pull request as ready for review July 21, 2022 14:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 21, 2022
@Mab879 Mab879 added this to the 0.1.64 milestone Jul 21, 2022
@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. ANSSI ANSSI Benchmark related. labels Jul 21, 2022
@Mab879 Mab879 self-assigned this Jul 21, 2022
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good; it just needs a rebase.

Thanks for the PR.

@codeclimate
Copy link

codeclimate bot commented Jul 22, 2022

Code Climate has analyzed commit e48289e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit dff6f61 into ComplianceAsCode:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ANSSI ANSSI Benchmark related. needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants