Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve regex to match retry parameter in pwquality.conf #9245

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Improve regex to match retry parameter in pwquality.conf #9245

merged 2 commits into from
Jul 29, 2022

Conversation

marcusburghardt
Copy link
Member

Description:

It is possible that the retry parameter in pwquality.conf is preceded by space.

Rationale:

It is a corner case I identified during some tests and the fix is pretty simple.

@marcusburghardt
Improve regex to match retry parameter
3447731 
It is possible that the retry parameter in pwquality.conf is preceded
by space.
@marcusburghardt marcusburghardt added the OVAL OVAL update. Related to the systems assessments. label Jul 27, 2022
@marcusburghardt marcusburghardt added this to the 0.1.64 milestone Jul 27, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@jan-cerny
Copy link
Collaborator

It would be amazing to have a test scenario covering this situation 😉

@marcusburghardt
Include test scenario for accounts_password_pam_retry rule
43a9950 
It was included a test scenario which consider the retry parameter
preceeded by space in pwquality.conf file. Also, some minor improvements
were made in existing test scenarios.
@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label Jul 28, 2022
@codeclimate
Copy link

codeclimate bot commented Jul 28, 2022

Code Climate has analyzed commit 43a9950 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2022

@marcusburghardt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate 43a9950 link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-rhcos4-high 43a9950 link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jan-cerny jan-cerny self-assigned this Jul 29, 2022
@jan-cerny jan-cerny merged commit 8bc1af3 into ComplianceAsCode:master Jul 29, 2022
@marcusburghardt marcusburghardt deleted the accounts_password_pam_retry_oval_regex branch July 29, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
OVAL OVAL update. Related to the systems assessments. Test Suite Update in Test Suite.
Projects
None yet
Milestone
0.1.64
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcusburghardt @jan-cerny