Fix bash remediation in rsyslog_remote_access_monitoring rule

[marcusburghardt]

Description:

In cases where a reference line is not found, a new line was included with invalid syntax.
Removed the escape characters only necessary in the sed command used by this remediation.

Rationale:

• Fixes rsyslog_remote_access_monitoring bash remediation mangles config file in some cases #8204

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_rsyslog_remote_access_monitoring' differs:
--- old datastream
+++ new datastream
@@ -20,7 +20,7 @@
 # Add selector to file
 sed -r -i "0,/^(\S+\s+\/var\/log\/secure$)/s//\1\n${K} \/var\/log\/secure/" /etc/rsyslog.conf
 else
- echo "${K} \/var\/log\/secure/" >> /etc/rsyslog.conf
+ echo "${K} /var/log/secure" >> /etc/rsyslog.conf
 fi
 fi
 done

[codeclimate]

Code Climate has analyzed commit aff1de7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

[openshift-ci]

@marcusburghardt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-rhcos4-high	aff1de7	link	true	/test e2e-aws-rhcos4-high
ci/prow/e2e-aws-rhcos4-moderate	aff1de7	link	true	/test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jan-cerny]

Can you add a test scenario covering this situation?

[marcusburghardt]

Can you add a test scenario covering this situation?

The OVAL is not checking the destination of the logs but only if they are collected.
To include a test scenario, it would also be necessary to modify the OVAL to consider all possible values of log destination. I think it would create unnecessary complexity for the moment.

[jan-cerny]

That makes sense.

Basically, we can only test bugs that cause not passing OVAL check.