Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSE SLE15 add messagebus and nscd to authorized_local_users #9260

Merged

Conversation

brett060102
Copy link
Contributor

the accounts messagebus and nscd are normally present on SUSE SLE15
systems and so should be included in authorized_local_users_regex.

Description:

  • add messagebus and nscd to authorized_local_users_regex

Rationale:

  • rule xccdf_org.ssgproject.content_rule_accounts_authorized_local_users is failing for SLE15 SP4 even if not additional local accounts have been created because the system accounts for messagebus and nscd are not in the regex.

the accounts messagebus and nscd are normally present on SUSE SLE15
systems and so should be included in authorized_local_users_regex.
@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2022

Hi @brett060102. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 28, 2022
@Mab879
Copy link
Member

Mab879 commented Jul 28, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Jul 28, 2022
@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates. labels Jul 28, 2022
@Mab879 Mab879 added this to the 0.1.64 milestone Jul 28, 2022
@Mab879 Mab879 self-assigned this Jul 28, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jul 28, 2022

Code Climate has analyzed commit c6a32f3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 128fbf6 into ComplianceAsCode:master Jul 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2022

@brett060102: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-high c6a32f3 link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@brett060102 brett060102 deleted the SUSE_authorized_local_users_regex branch June 28, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants