-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kubernetes remediation for rule configure_crypto_policy #9266
Add Kubernetes remediation for rule configure_crypto_policy #9266
Conversation
Hi @Vincent056 it seems like the e2e tests are catching some issue here:
|
6c0e9ae
to
eb61041
Compare
/retest |
eb61041
to
54c66da
Compare
Added Kubernets auto remediation for rule configure_crypto_policy
54c66da
to
e98fb03
Compare
Remove e2e test, |
Code Climate has analyzed commit e98fb03 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 42.7% (0.0% change). View more on Code Climate. |
/retest |
@Vincent056: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
So now the tests related to your rule are all passing, but here is this failure:
Because other rhcos4 rules are passing, I wonder if we have an issue with installing usbguard? |
Yes, this rule passes manually for me |
/bugzilla cc-qa |
1 similar comment
/bugzilla cc-qa |
/label qe-approved |
@xiaojiey: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
test cases details could be seen from: https://url.corp.redhat.com/8162b96 |
Thanks for adding the test case, it looks good to me |
thank you, tested manually. As I said in the other PR, let's add a card and disable the offending test for now |
Added Kubernets auto remediation for rule
configure_crypto_policy
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2062530