Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support commas in variables #9280

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

jan-cerny
Copy link
Collaborator

This adds support for commas in variable values in the test
scenarios metadata in the variables key. For example:
# variables = sshd_approved_ciphers=ijkl158,sits,wwq-98,kl24

Fixes: #7553

This adds support for commas in variable values in the test
scenarios metadata in the `variables` key. For example:
`# variables = sshd_approved_ciphers=ijkl158,sits,wwq-98,kl24`

Fixes: ComplianceAsCode#7553
@jan-cerny jan-cerny added the Test Suite Update in Test Suite. label Aug 2, 2022
@jan-cerny jan-cerny added this to the 0.1.64 milestone Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 2, 2022

Code Climate has analyzed commit ec28ce8 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

@jan-cerny: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate ec28ce8 link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-rhcos4-high ec28ce8 link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@matusmarhefka matusmarhefka self-assigned this Aug 2, 2022
@matusmarhefka matusmarhefka merged commit 4f07a1e into ComplianceAsCode:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSGTS variables metadata cannot have comma as a separator
2 participants